Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toggle]: Fix toggles not toggling #25966

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[Toggle]: Fix toggles not toggling #25966

merged 1 commit into from
Oct 14, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Oct 13, 2024

Resolves brave/brave-browser#41493

Note: This should be uplifted to 1.72

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 13, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works great for both cases in brave/brave-browser#41493 🙂👍

@bsclifton bsclifton merged commit e49d346 into master Oct 14, 2024
18 checks passed
@bsclifton bsclifton deleted the fix-toggles branch October 14, 2024 05:38
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 14, 2024
brave-builds added a commit that referenced this pull request Oct 14, 2024
bsclifton added a commit that referenced this pull request Oct 14, 2024
[Toggle]: Fix toggles not toggling
@brave-builds
Copy link
Collaborator

Released in v1.73.9

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.73.20 Chromium: 130.0.6723.58 (Official Build) nightly (64-bit)
-- | --
Revision | 363777613b877e60655632bb3570327ce6baeafd
OS | Windows 11 Version 23H2 (Build 22631.4317)
  1. Installed 1.73.20
  2. launched Brave
  3. created sync chain in the profile
  4. created a second profile via hamburger menu
  5. joined the sync chain
  6. toggled Sync data on/off
  7. added an extension via chrome webstore
  8. opened brave://settings/extensions in a new tab
  9. clicked Details
  10. toggled on for Allow in Private
  • Confirmed Sync data toggles worked as expected in both profiles
  • Confirmed toggle worked for Private window and working as expected
2024-10-17_10h44_32.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many toggles broken (Extensions, Sync) in Brave 1.72 and newer
5 participants